PyTado icon indicating copy to clipboard operation
PyTado copied to clipboard

Test-refactor

Open erwindouna opened this issue 11 months ago • 4 comments

Description

Attempt to rewrite the test and utilize the poetry structure.


Related Issues

Link any related issues that this pull request resolves or is associated with:


Type of Changes

Mark the type of changes included in this pull request:

  • [ ] Bugfix
  • [ ] New Feature
  • [ ] Documentation Update
  • [ ] Refactor
  • [ ] Other (please specify):

Checklist

  • [ ] I have tested the changes locally and they work as expected.
  • [ ] I have added/updated necessary documentation (if applicable).
  • [ ] I have followed the code style and guidelines of the project.
  • [ ] I have searched for and linked any related issues.

Additional Notes

Add any additional comments, screenshots, or context for the reviewer(s).


Thank you for your contribution to PyTado! 🎉

erwindouna avatar Jan 15 '25 21:01 erwindouna

@erwindouna do we have to update the gitlab workflow too? currently it is mostly failing!

wmalgadey avatar Jan 16 '25 07:01 wmalgadey

@erwindouna do we have to update the gitlab workflow too? currently it is mostly failing!

I can work on them to get operational. I added as an extra to utilize Poetry to manage the project.

erwindouna avatar Jan 16 '25 08:01 erwindouna

@erwindouna ahould we merge this change? Or are there some more todos we should finish first?

wmalgadey avatar Jan 19 '25 16:01 wmalgadey

Why more todo's. It's a first start. I see now that there's already quite some other refactor work. So let's await that first. :)

erwindouna avatar Jan 20 '25 14:01 erwindouna