PyTado icon indicating copy to clipboard operation
PyTado copied to clipboard

[Feature]: Better Tado X support

Open wmalgadey opened this issue 1 year ago • 2 comments

Describe the Feature

Currently we just integrated the needed API (hops.tado.com), but we should integrate the Tado X devices seamlessly, so that the homeassistant integration can be used with both old and new devices.


Why Is This Feature Useful?

Integrating new devices always makes sense 😄


Proposed Solution

Tado X can already be accessed with 0.18.5, but we should also respect the homeassistant integration to make the usage seamless.


Alternatives Considered

List any alternative approaches or features you considered and why they might not work as well.


Additional Context

Add any other context, screenshots, or examples that help explain your request.


Checklist

  • [ ] I have searched the existing issues and discussions to ensure this is not a duplicate.
  • [ ] I have provided a clear and concise description of my feature request.
  • [ ] I have included any relevant examples or details to support my proposal.

Thank you for helping to improve PyTado! 🚀

wmalgadey avatar Dec 24 '24 09:12 wmalgadey

For reference: https://github.com/home-assistant/core/issues/132070

wmalgadey avatar Dec 24 '24 09:12 wmalgadey

because of the changes here regarding to tado x we had to revert to and older version in homeassistant -> https://github.com/home-assistant/core/pull/132510

wmalgadey avatar Dec 24 '24 09:12 wmalgadey

Hi all - I'd really love to help support this happening; I upgraded to TadoX and now can't do the automations etc that I could do with Home Assistant.

I'm quite capable with Python and would love to get in and support this - though I can't see a good list of what is left/needs to happen, how can I help?

micsco avatar May 11 '25 11:05 micsco

Hi all - I'd really love to help support this happening; I upgraded to TadoX and now can't do the automations etc that I could do with Home Assistant.

I'm quite capable with Python and would love to get in and support this - though I can't see a good list of what is left/needs to happen, how can I help?

Why cant you do them? It's a bit fiddly, and needs reauthorisation after any HA update, but with the workaround mine works fine.

EACourts avatar May 11 '25 17:05 EACourts

Hi all - I'd really love to help support this happening; I upgraded to TadoX and now can't do the automations etc that I could do with Home Assistant.

I'm quite capable with Python and would love to get in and support this - though I can't see a good list of what is left/needs to happen, how can I help?

Hi @micsco, thanks for wanting to help! You can take a look at the PR #204 , I've written down some stuff that's left to do for PyTado v1.0.0 (which will have way better TadoX Support) there. Also, I left some TODO-Comments in the code in the pytado-v1.0 branch.

Maybe you can take a look at the HA-Integration and find stuff that would be better done in the library. (And, after PyTado v1.0.0 is released, the HA Integration needs to be updated to use the new library version.)

I'd also appreciate any feedback on the stuff I've done in v1.0.0 and ideas and thoughts what could be done better.

Moritz-Schmidt avatar May 12 '25 09:05 Moritz-Schmidt

Thanks @Moritz-Schmidt - I'll have a look!

micsco avatar May 12 '25 19:05 micsco

Hi! As the winter is approaching slowly but steadily, I think it would be a great time to start working again on PyTado 1.0 with proper Tado X support.

Maybe we can collect what tasks are still open and distribute the work, so we have a chance to get this forward?

karlbeecken avatar Aug 28 '25 14:08 karlbeecken

Agreed Karl, been on my mind too.

In the discord I think we came to an agreement to backport the Tado x support in the long running branch back to the main branch, as they've diverged a bit.

We can break that up and manage it more successfully I think.

We should also think about and call out the breaking changes we want to / need to make (e.g. async, httpx, API changes)

Mike Scott

On Thu, 28 Aug 2025, 15:12 Karl Beecken, @.***> wrote:

karlbeecken left a comment (wmalgadey/PyTado#117) https://github.com/wmalgadey/PyTado/issues/117#issuecomment-3233668542

Hi! As the winter is approaching slowly but steadily, I think it would be a great time to start working again on PyTado 1.0 with proper Tado X support.

Maybe we can collect what tasks are still open and distribute the work, so we have a chance to get this forward?

— Reply to this email directly, view it on GitHub https://github.com/wmalgadey/PyTado/issues/117#issuecomment-3233668542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHSUFJN3EAAV4Z5IJV4HT3P4E4PAVCNFSM6AAAAABUENERUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMZTGY3DQNJUGI . You are receiving this because you were mentioned.Message ID: @.***>

micsco avatar Aug 28 '25 14:08 micsco

Agreed Karl, been on my mind too.

In the discord I think we came to an agreement to backport the Tado x support in the long running branch back to the main branch, as they've diverged a bit.

We can break that up and manage it more successfully I think.

We should also think about and call out the breaking changes we want to / need to make (e.g. async, httpx, API changes)

Mike Scott +44 7474 945849

Do you have the link to the discord per any chance?

karlbeecken avatar Aug 28 '25 14:08 karlbeecken

@karlbeecken https://github.com/wmalgadey/PyTado/discussions/174

wmalgadey avatar Aug 28 '25 14:08 wmalgadey

just for reference: https://github.com/home-assistant/core/issues/151223

wmalgadey avatar Aug 28 '25 14:08 wmalgadey

master now contains all relevant changes from tadox and is ready for version 1.0.0 (hopefully 😄 )

wmalgadey avatar Oct 09 '25 23:10 wmalgadey