wlav comments

Results 359 comments of


                                            wlav

`TypeError` instead of common exception type for overloaded functions

Going through old reports ... this was fixed with https://github.com/wlav/CPyCppyy/commit/02072bbd818501364b37c133364e02976af4cc10 and released with cppyy 3.5.0.

Use PyMapping_GetOptionalItemString where necessary with Python 3.13

Interesting, since even with py13, https://github.com/wlav/cppyy/issues/273 doesn't fail for me.

Use PyMapping_GetOptionalItemString where necessary with Python 3.13

As for the PR, I'm much rather use a more descriptive name and put a compatibility function in `CPyCppyy.h`. I'll do that later: I'm going to remove all Python2 stuff,...

Converters from numpy types to corresponding C++ types gone missing

Was support for `numpy` types added to the ROOT fork of cppyy? AFAIK, this has never worked in master.

libcppyy_backend.so is duplicated in the wheel

Interesting; never saw that error before. Should be fixed now, although I don't quite understand how/why. Must have been some changes in pip behavior over time.

clingwrapper-1.15.3 depends on old version of cppyy-cling

Thanks ... looks like I updated the `setup.py` files, but not the `project.toml` files. :/

fix iadd pythonization for np/array buffers

Don't change the indentation convention (the patch goes to 2 spaces instead of 4 for some reason). If the `insert` fails, just return `nullptr`. The error set at that point...

Add converters and low-level views for fixed width types

I'm surprised if this compiles ... I'd be even more surprised if any of these converters are ever called.

Add converters and low-level views for fixed width types

Not sure; certainly there are differences: that `cppdef` crashes in Cling when using master (should be `cppexec`, although it should crash, of course) and that `cast` fails to convert but...

Provide private API to set CPPInstance `reduce` callback

This implementation means there can only ever be 1 reduce method, or can it now be overridden in a derived class? If the latter, isn't it sufficient to make this...