CPyCppyy icon indicating copy to clipboard operation
CPyCppyy copied to clipboard

Correcly forward `control` flag to InstancePtrConverter

Open guitargeek opened this issue 1 year ago • 2 comments

Closes https://github.com/wlav/cppyy/issues/221, if the change in memory policy was accidental.

This fixes the memory test in the synchronization PR: https://github.com/root-project/root/pull/14507

guitargeek avatar Mar 13 '24 03:03 guitargeek

Hi @wlav, do you need any more information from my side before merging this? I have a reproducer for the problem in the associated issue

guitargeek avatar May 14 '24 21:05 guitargeek

These and other PRs need tests. It's best practice to have tests but it's also in your own interest as it will pre-empt regressions.

wlav avatar May 14 '24 21:05 wlav

You are right! I have opened a PR with a unit test that will pass once this is merged.

  • https://github.com/wlav/cppyy/pull/244

guitargeek avatar Jun 07 '24 11:06 guitargeek