tunneldigger icon indicating copy to clipboard operation
tunneldigger copied to clipboard

Sync version number with openwrt/lede package

Open kaechele opened this issue 7 years ago • 7 comments

The openwrt package currently lists a different version than is tagged in the tunneldigger repo. We should work to keep them in sync in the future.

kaechele avatar Dec 09 '17 20:12 kaechele

See also: https://github.com/wlanslovenija/firmware-packages-opkg/pull/11

kaechele avatar Dec 09 '17 20:12 kaechele

Releasing a new version for the fix with new kernels makes sense, I think. I was going to advocate for that once #66 is merged.

RalfJung avatar Dec 10 '17 10:12 RalfJung

I think that I will tag a new version soon, but still gotta think what the appropriate version would be. I mean, we can move to 1.0 as far as I am concerned

robimarko avatar Nov 03 '18 09:11 robimarko

I am not sure about 1.0, maybe that should wait for IPv6 support and some more research into figuring out why we need all that NAT hackery?

gluon, which also includes a tunneldigger package, seems to just use date and git SHA instead of a version number, so there is no version constraint there. Looking at https://github.com/wlanslovenija/firmware-packages-opkg/blob/master/net/tunneldigger/Makefile, maybe the next version should be 0.5.0?

@robimarko what does it take to make a version, beyond pushing a tag?

RalfJung avatar Dec 02 '18 20:12 RalfJung

Well, we can wait for IPv6 but I don't think that anybody is developing Tunneldigger at all.

In Otvorena mreza we also use latest GIT tag.

We can simply push a tag and edit it in source as its referenced couple of times

robimarko avatar Dec 02 '18 20:12 robimarko

Just to be clear, I think 0.5 is fine any time, just for 1.0 I feel it should be "more ready". But I don't care strongly, and I certainly agree it's about time to have a tag again.

RalfJung avatar Dec 02 '18 20:12 RalfJung

For me 0.5 is fine also, its been way too long and a lot of changes in meantime have happened. Only issue I am having current commit is that init script on OpenWrt for broker is broken.

robimarko avatar Dec 02 '18 20:12 robimarko

@pmelange can you make sure that the version 0.4.0 is getting used properly on the lede side?

RalfJung avatar Aug 19 '23 15:08 RalfJung

Yes, doing a test build now.

pmelange avatar Aug 19 '23 16:08 pmelange

@pmelange can you make sure that the version 0.4.0 is getting used properly on the lede side?

Merged https://github.com/openwrt/packages/pull/21752

pmelange avatar Aug 23 '23 07:08 pmelange

Please feel free to close this issue

pmelange avatar Aug 23 '23 07:08 pmelange