Sidhartha Mani

Results 29 comments of Sidhartha Mani

Could you please close the other one: https://github.com/kubernetes/enhancements/issues/1593 Looks like john created that project before he left the group

Thanks for adding this issue. I like this feature request. tbh, we've already done things like this - https://medium.com/@utter_babbage/breaking-the-type-system-in-golang-aka-dynamic-types-8b86c35d897b. I can add support for this, however find myself short on...

> (Also, while half that post went over my head, it was a super interesting read!) thanks! :+1:

@dolmen Thanks for sharing this. It's really well documented - Love it!

> Is it feasible to break the PR into smaller commits to cover various parts of it? Done!

The PR is still valid. Only reason we couldn't merge was because we were waiting for containerd-1.6, which provides the APIs needed to implement portforward (https://github.com/dmcgowan/containerd/commit/5b3c33590712875b9ed17bb269525e4c837719c6) I haven't followed up...