completely disable the use of selenium wire
close #274
Many thanks for the PR! Yes having an option to disable Selenium Wire programmatically sounds like it could be useful. I've made a couple of comments and would be happy to merge if you're able to resolve.
Codecov Report
Merging #275 (4780272) into master (5f27924) will decrease coverage by
0.95%. The diff coverage is52.77%.
:exclamation: Current head 4780272 differs from pull request most recent head 0d17d64. Consider uploading reports for the commit 0d17d64 to get more accurate results
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 86.04% 85.08% -0.96%
==========================================
Files 13 13
Lines 1096 1120 +24
==========================================
+ Hits 943 953 +10
- Misses 153 167 +14
| Impacted Files | Coverage Δ | |
|---|---|---|
| seleniumwire/webdriver.py | 39.65% <52.77%> (+0.52%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5f27924...0d17d64. Read the comment docs.
Thanks for making the changes - all looks good.
I've just run the code with undetected chromedriver and realized that we're going to need to wait for your other PR to get merged first, otherwise undetected chromedriver will raise:
TypeError: __init__() got an unexpected keyword argument 'chrome2use'
So once that undetected chromedriver PR is merged we're good to merge this one.
Thanks again!
okay, thanks