wkania
wkania
In 2021 carsonbot removed [Validator] from the title. Now we are back to the original title :).
Fixed merge conflict. [Commit](https://github.com/symfony/symfony/commit/f4118e110a46de3ffb799e7d79bf15128d1646ea) was the reason
@nicolas-grekas So that there are no misunderstandings. So I shouldn't have used github UI to resolve merge conflict? I can squash all 38 commits into one?
ok, I'll do it later today
It will be more complex :( When there is a second optional argument: ``` #[Security("is_granted('ROLE_FRIENDLY_USER', author'])")] public function showAction(User $author): Response ``` ``` #[IsGranted(attribute: new Expression("is_granted('ROLE_FRIENDLY_USER', subject['author'])"), subject: ['author'])] public...
@pepeh Yes, you are right. My example was to simple. In my opinion, these are the valid cases and probably many [more](https://symfony.com/doc/current/security/expressions.html): ------------------- #[Security("is_granted('ROLE_ADMIN')")] #[IsGranted('ROLE_ADMIN')] ------------------- #[Security("is_granted('ASSET_EDIT', asset)")] #[IsGranted('ASSET_EDIT', 'asset')]...
Yes, the [built-in](https://github.com/symfony/translation-contracts/blob/main/TranslatorTrait.php#L38) non-standard Symfony way for translations is not documented. For the not ICU MessageFormat filenames, you can use Twig like placeholders: ``` # translations/messages.en.yaml say_hello: Hello %name%. Symfony...
Good, you found it. I broke untested code.
@xabbuh could you please review this PR? Thx