Will Jones

Results 534 comments of Will Jones

> (RecordBatchReader does have Close but I don't think the record batch reader that R uses today has an implemented close method) The R record batch reader does implement `Close()`,...

> Perhaps a more general fix would be that, when we broadcast a scalar, if the type is a binary data type, we could always broadcast it into a dictionary...

Looking at the R test failures, it seems like this change is blocked because hash join and aggregate don't support unifying dictionaries. Thinking about it, having to do that might...

`StructArray$create()` was added in #31660.

As is, the binary encoding can't differentiate between empty string and null. I wouldn't be surprised if later someone asks for that to be fixed. Also, we don't error if...

For IVF+PQ, this will work but may use up more memory, since all partitions need to be kept in memory as they are merged (whereas previously we can just take...

Add a timeout so that it doesn't take unbounded time to return filtered results.

Superseded by scalar index + pre-filtering approach.

## On-disk mechanism The `Fragment.delete` method will have four possible outcomes: | Outcome | Storage representation | | --------| ---------| | No rows deleted | Fragment kept as is |...

There are two lingering follow-ups, so I'll close that when those are done.