accounting.js icon indicating copy to clipboard operation
accounting.js copied to clipboard

Add CDNJS version badge in readme

Open kennynaoh opened this issue 8 years ago • 5 comments

This will add the badge to show its version on CDNJS and also link to its page on CDNJS!

kennynaoh avatar Oct 18 '16 10:10 kennynaoh

@kennynaoh Thanks for this pull request. Mind submitting it on the openexchangerates/accounting.js repository?

wjcrowcroft avatar Jan 18 '17 14:01 wjcrowcroft

Hello @wjcrowcroft We add this library https://cdnjs.com/libraries/accounting.js on CDNJS already, but not this https://github.com/openexchangerates/accounting.js, so I can't submit the badge on it.

kennynaoh avatar Jan 19 '17 03:01 kennynaoh

@kennynaoh I see - https://github.com/openexchangerates/accounting.js is the official repository for the library, and this fork may not be maintained alongside it. Are you able to update the library on cdnjs.com to the correct base repository?

wjcrowcroft avatar Jan 19 '17 13:01 wjcrowcroft

@kennynaoh Also, the cdnjs.com page for accounting.js should be updated to use the correct homepage URL:

http://openexchangerates.github.io/accounting.js/

The previous URL doesn't exist any more and doesn't forward either.

(If this isn't something you're responsible for, could you please point us in the right direction for getting these updated? Thanks.)

wjcrowcroft avatar Jan 19 '17 13:01 wjcrowcroft

@wjcrowcroft So you want to update the git repo and the homepage on cdnjs? https://github.com/cdnjs/cdnjs/blob/master/ajax/libs/accounting.js/package.json#L26 BTW, whould you like to open an issue to fix the problems above on cdnjs? https://github.com/cdnjs/cdnjs/issues

kennynaoh avatar Jan 20 '17 03:01 kennynaoh