[Suggestion] Consider supporting YC cores

[felleg]

Hello! Thanks for the wonderful script, I use it a lot to streamline my gaming sessions :)

I noticed that I started gravitating towards the YC cores, for native S-video output: https://github.com/MikeS11/MiSTerFPGA_YC_Encoder/tree/main/YC%20Builds

Unfortunately, the current script doesn't consider the existence of these cores on my MiSTer. For example, when I create a new favorite for a Genesis game, the .mgl file will specify to launch this game from the default Genesis core.

Here is a modification I made to favorites.sh on my setup to use my preferred cores, when available:

else:
    core = "_Console/GenesisYC"   # <------------- This line is modified
MGL_MAP = MGL_MAP + (("Genesis", core, (({".bin", ".gen", ".md"}, 1, "f", 0),)),)

This crude modification works for me, but I'm letting you know about it in case you want to make a more robust implementation, as YC cores gradually start making their way in. :)

Keep up the good work, and thanks again!

[wizzomafizzo]

Hi. Thanks for the request. I like the idea a lot of supporting custom cores like this and definitely want to include the feature. Recently I accepted a patch to support the llapi cores as well

I'll need some time to think about this though. The implementation becomes a bit tricky with multiple custom options. It's unlikely someone has more than one alternate core on their system but it could be possible, and I'd like the support to be robust enough like you said

I'll let you know how it goes

[wizzomafizzo]

@felleg and @kerobaros can I please ask your help to test a new version that will support LLAPI and YC cores

https://github.com/wizzomafizzo/MiSTer_Favorites/raw/main/favorites_altcores.sh

Put this in your scripts folder. You can keep the old script there too

Then create a file called favorites.ini in the Scripts folder with this contents:

[cores]
all=llapi

or

[cores]
all=yc

Then run favorites_altcores.sh and try add some favorites as normal. Let me know how it goes!

@kerobaros I apologise but I had to replace all the code you wrote! But I really appreciate you wrote it in the first place or else I would have had a lot more trouble getting this new solution done

[felleg]

Tested it with an NES game with the YC core, worked fine on the first try! Huge thanks @wizzomafizzo! 🙌🏻 Feel free to close this issue.

[wizzomafizzo]

Thanks for testing! Glad it worked ok. I'll keep it open for now until I know llapi works too. There's probably some more details to work out

[LuckyNES]

@wizzomafizzo I can't download the code on that link. It seems to be broken. I tried just adding an ini like you said on the latest version of the script on github and it doesn't seem to start the YC cores for me. Anything you can do? Even if it is reposting that working script? Thank you.