Helen Lin

Results 79 comments of Helen Lin

Closed - Will be included as part of new Product form PR https://github.com/Shopify/hydrogen/pull/2482

Reopen - The other PR is is being delayed

@dcodrin I have a fix coming for this. https://github.com/Shopify/hydrogen/pull/2590 `ErrorBoundary` are working as they should. This is a problem within the `Analytics.Provider`. I'll have this ship out next week before...

@rbshop and I just went thru this PR and addressed some feedbacks. Usage update: Converted from inline parameters to a single object - making `shouldCacheResult` mandatory parameter ```diff - withCache(cacheKey,...

Already done in another PR

The issue it that the package itself expects to have a `window` or `document` to be available in the SSR side. Hydrogen local server uses Cloudflare workerd instance. This is...

Then I would consider using [dompurify](https://www.npmjs.com/package/dompurify) + jsdom. * dompurify - gives you the html sanitization method * jsdom - provides the `window` object that dompurify needs on the server...

It depends on the hosting environment you are on. Some hosting platform supply a global.windows object and some don't. For example, Vercel and Cloudflare workers (what Oxygen is using) doesn't...