pleb icon indicating copy to clipboard operation
pleb copied to clipboard

Running `upgrade` un-pins dependencies

Open tzachbon opened this issue 2 years ago • 2 comments

When running upgrade it also "un-pins" a version even though it wasn't upgraded (also to upgraded requests).

image

It's a little unexpected. Shouldn't it keep the request status (minor, patch, pinned)?

tzachbon avatar Dec 21 '22 01:12 tzachbon

It's actually on purpose. Whether it is correct to do so, could be argued... Especially in a semver ecosystem and when making use of lock files.

You can tell pleb to ignore specific dependencies using pleb.config.js/mjs: https://github.com/wixplosives/pleb#configuration-file

AviVahl avatar Dec 21 '22 06:12 AviVahl

It's actually on purpose. Whether it is correct to do so, could be argued... Especially in a semver ecosystem and when making use of lock files.

You can tell pleb to ignore specific dependencies using pleb.config.js/mjs: wixplosives/pleb#configuration-file

I agree with you, but there could be a case where an installed library would like a specific version, and we know it can't control its user's lock file so the author has to pin the version in the package json file. In that case, the library author can't use pleb to upgrade it and would have to do it manually.

tzachbon avatar Dec 21 '22 18:12 tzachbon