stylable icon indicating copy to clipboard operation
stylable copied to clipboard

Mistakes of Workload calculation

Open fly-dragon211 opened this issue 1 year ago • 5 comments

The calculation of $Mss_{GPU}$ and $Mss_{CPU}$ may have some mistakes. The following is my calculation procedure:

image

while in the paper: image

fly-dragon211 avatar Mar 08 '23 11:03 fly-dragon211

i think they do make the mistake :(

shadow150519 avatar Mar 27 '23 14:03 shadow150519

The calculation of MssGPU and MssCPU may have some mistakes. The following is my calculation procedure:

image

while in the paper: image

Can you tell me do they build the system using the wrong result or just a slip of the pen ?

shadow150519 avatar Mar 27 '23 14:03 shadow150519

@shadow150519 Yes, this is a typo in the paper. Despite the typo, the final conclusion in equation (6) is right and BytePS correctly implements the traffic allocation strategy. Thank you for pointing out this.

ymjiang avatar Mar 28 '23 01:03 ymjiang

@ymjiang base on tc = tg and eq3, eq4, eq5, i get the following result

$$ M_{ss_{GPU}} = \frac{k - 1}{-kn + 2k -n}*M $$

$$M_{ss_{CPU}} = \frac{2(1-n)}{-kn+2k-n}*M$$

and the topt should be the following result

$$ t_{opt} = \frac{2(1-n)}{(-kn+2k-n)*B}*M $$

eq7 is wrong and should be the following

$$ \gamma_{\alpha} = \frac{\frac{2(n-1)M}{nB}}{t_{opt}} = \frac{kn-2k + n}{n} $$

$$ \gamma_{p} = \frac{\frac{nM}{kB}}{t_opt} = \frac{n(-kn+2k-n)}{2k(1-n)}$$

i think these should be the correct result

shadow150519 avatar Mar 28 '23 04:03 shadow150519

i think you do the calculation totally wrong in section 4.1

shadow150519 avatar Mar 28 '23 04:03 shadow150519