react-native-ui-lib
react-native-ui-lib copied to clipboard
Use rowGap and columnGap feature in our GridList and SortableGridList…
Description
Use rowGap and columnGap feature in our GridList and SortableGridList components We had issue with extra item spacing in the last row of the grid This fix the issue and also use a better way to add gutter (item spacing) between grid items
Changelog
Fix GridList and SortableGridList item spacing issue (using gap feature)
Additional info
BTW, we currently have a somewhat awkward solution to this in SortableList - we've added itemProps with margins in it.
It does allow for horizontal margins as well, but I'm not sure it's a must in a list.
We can try to change the API in the next major version, WDYT?
(It should still be a dedicated prop because we need this info for the dragging height calculation)
BTW, we currently have a somewhat awkward solution to this in
SortableList- we've addeditemPropswithmarginsin it. It does allow for horizontal margins as well, but I'm not sure it's a must in a list. We can try to change the API in the next major version, WDYT? (It should still be a dedicated prop because we need this info for the dragging height calculation)
I'm less familiar with it TBH, if you feel we need to change something there then open a PR