Fix image svg

[mendyEdri]

Description

Until now, all images with url used SvgImage component, because source was a url and isSvg returned true.

Changelog

Added support for Image web

Additional info

[mendyEdri]

I added some comments, but... I have to say that I don't like this solution, it'll require Uilib to maintain two image files, and I'm confident that it will be forgotten. react-native-web supports RN's Image, so we should re-check what doesn't work and close the gaps. Until now we added the .web files only when something isn't supported on the web and I think we should keep doing it instead of duplicating to code.

I don't mind. atm in production sources with type of string (either source={url} or images actual data) are rendering the SVG component which causes issues and left us with production bugs.

Also, the current mobile image implementation cannot render ImageBackground properly in web. moreover, using the mobile image, rendered styling weird, and wasn't affecting by image-ratio prop.

I suggest to assign someone from the team to address it :) thanks!

[OrenZak]

I added some comments, but... I have to say that I don't like this solution, it'll require Uilib to maintain two image files, and I'm confident that it will be forgotten. react-native-web supports RN's Image, so we should re-check what doesn't work and close the gaps. Until now we added the .web files only when something isn't supported on the web and I think we should keep doing it instead of duplicating to code.

I don't mind. atm in production sources with type of string (either source={url} or images actual data) are rendering the SVG component which causes issues and left us with production bugs.

Also, the current mobile image implementation cannot render ImageBackground properly in web. moreover, using the mobile image, rendered styling weird, and wasn't affecting by image-ratio prop.

I suggest to assign someone from the team to address it :) thanks!

@ethanshar can you help ?

[ethanshar]

Is this PR still relevant? can we close it?

[mendyEdri]

Is this PR still relevant? can we close it?

It is. Removing it, still breaking images in web-editor

[ethanshar]

But we don't use this fix, it's not merged. Is there still an issue with SVG?

[mendyEdri]

But we don't use this fix, it's not merged.

Is there still an issue with SVG?

We do, we use this version in web-editor. And yes, there is still an issue

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ethanshar]

@mendyEdri Is this PR still relevant?

[mendyEdri]

@mendyEdri

Is this PR still relevant?

Not anymore 💪