react-native-ui-lib icon indicating copy to clipboard operation
react-native-ui-lib copied to clipboard

VSCode not suggesting the component's props

Open thanhloc-17 opened this issue 2 years ago • 3 comments

This problem occur when I update new version or RNUILib, then I type some prop and VSCode not suggest any props image

With the others package, the IntelliSense still working well.

Thanks

thanhloc-17 avatar Aug 31 '22 13:08 thanhloc-17

having same issue on react native v0.70 .

ramssutharr avatar Sep 13 '22 09:09 ramssutharr

Me too!

qkudev avatar Sep 17 '22 16:09 qkudev

up

thanhloc-17 avatar Oct 14 '22 07:10 thanhloc-17

any news on this? @ethanshar

tarikfp avatar Oct 22 '22 17:10 tarikfp

Same on my side. I get key and ref as the only two available props It is happening on some imported (checked on Text and Image as of now) components from the library

import { Image } from 'react-native-ui-lib';

image

However if I import from:

import { Image } from 'react-native-ui-lib/src/components/image';

Props show up properly. So there must be something wrong with the way the components are being exported from some index

Using react-native-ui-lib v6.22.1 react-native v0.69.6

lakardion avatar Oct 24 '22 13:10 lakardion

any updates or hints on what might be wrong?

The-White-Fang avatar Nov 25 '22 14:11 The-White-Fang

possible duplicate of https://github.com/wix/react-native-ui-lib/issues/2202 ?

The-White-Fang avatar Nov 25 '22 14:11 The-White-Fang

same issue here

KishoreBarik avatar Dec 13 '22 09:12 KishoreBarik

up

thanhloc-17 avatar Jan 07 '23 07:01 thanhloc-17

up

thanhloc-17 avatar Feb 09 '23 03:02 thanhloc-17

Issue still persists on RN 0.70.5 and react-native-ui-lib: 7.1.0

chrismerino avatar Feb 22 '23 20:02 chrismerino

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 01 '23 15:05 stale[bot]

Hi, is this issue still relevant? I don't experience it

ethanshar avatar May 09 '23 14:05 ethanshar

I still experience it on 7.3.5

henry-infevo avatar May 14 '23 04:05 henry-infevo

Screenshot 2023-05-14 at 11 45 32 It looks like the components is losing props type.

henry-infevo avatar May 14 '23 04:05 henry-infevo

Hi, is this issue still relevant? I don't experience it

Could you share your tsconfig.json please? We may have to add something to it to make it work. Starting a new project from scratch and installing the lib doesn't work for us.

A workaround I found was to remove the global type ThemeComponent and place it in an export statement. But that seems like something that will never be in the official repo. I am still looking into it and will let you know if I can find something else to fix it.

Edit: I noticed that generated d.ts files don't have any reference to ThemeComponent. image

Maybe that is the problem here.

The-White-Fang avatar May 21 '23 12:05 The-White-Fang

my tsconfig below:

{
  "extends": "expo/tsconfig.base",
  "compilerOptions": {
    "strict": true,
    "baseUrl": ".",
    "typeRoots": ["./node_modules/@types", "./@types"]
  }
}

p.s: I defined global ThemeComponent but it doesn't work.

henry-infevo avatar May 23 '23 14:05 henry-infevo

Hi, is this issue still relevant? I don't experience it

Could you share your tsconfig.json please? We may have to add something to it to make it work. Starting a new project from scratch and installing the lib doesn't work for us.

A workaround I found was to remove the global type ThemeComponent and place it in an export statement. But that seems like something that will never be in the official repo. I am still looking into it and will let you know if I can find something else to fix it.

Edit: I noticed that generated d.ts files don't have any reference to ThemeComponent. image

Maybe that is the problem here.

I was right, it turns out that if you define your types in d.ts files, they will be excluded from your build. The solution to this would be to move the global types to imported types.

The-White-Fang avatar May 28 '23 10:05 The-White-Fang

Should be fixed with the above PR

M-i-k-e-l avatar Jul 24 '23 13:07 M-i-k-e-l

Any news? Still experience it on 7.6.0

Revolt9k avatar Aug 07 '23 11:08 Revolt9k

a885dfdb675025fd03d47119834f649462e056a4 was from Jul 24, 2023 and 7.6.0 is from before (July 20th), so we're still waiting for a new release.

vicdelfant avatar Aug 07 '23 11:08 vicdelfant

Should be fixed in version 7.7.0 that should be released next week

ethanshar avatar Aug 08 '23 05:08 ethanshar