react-native-navigation icon indicating copy to clipboard operation
react-native-navigation copied to clipboard

[Android] Fix safe area miscalculation on HONOR phones

Open Reeywhaar opened this issue 5 months ago • 4 comments

Somehow bottomButtons layout breaks keyboard safe area on Honor (MagicOs) phone models.

Description:

We have an app with bottomTabs layout. When we push some modal that has TextInput and focus it, adjustResize doesn't work and important views that are placed on bottom became hidden behind the keyboard. But only on Honor phones 🤷‍♂️

Initial screen: Screenshot_1754628010

Before fix: Screenshot_1754628261

After fix: Screenshot_1754628018

Additional info:

react-native: 0.77.3 (with some patches from here) react-native-navigation: 7.50.0 softInputMode is adjustResize

Disclaimer

This is more of something to think about, rather that thorough merge request, as I'm not an advanced android developer and this works only for my case, but may break ton of others. Screenshots are emulator representation of how it looks, not a real device screenshots.

Reeywhaar avatar Aug 08 '25 04:08 Reeywhaar

Hi, what android version you're running. It looks like a problem with edge to edge and not specific brand

gosha212 avatar Oct 30 '25 12:10 gosha212

Problem with edge2edge and HONOR specifically, because everything works fine on e.g Samsung. OS is MagicOS 9 (Android 15)

Reeywhaar avatar Oct 30 '25 12:10 Reeywhaar

I see there are new additions to BottomTabsController.java which may cover my PR already, though I need to test it. Maybe PR is already obsolete. I'll let you know as soon as I can.

Reeywhaar avatar Oct 30 '25 12:10 Reeywhaar

we still have to implement the edge to edge support

gosha212 avatar Oct 30 '25 14:10 gosha212

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 17 '25 22:12 stale[bot]

Fixed in newer releases, thank you!

Reeywhaar avatar Dec 17 '25 23:12 Reeywhaar