react-native-navigation icon indicating copy to clipboard operation
react-native-navigation copied to clipboard

Topbar clicks are passing through to the screen underneath the modal

Open Alberto-BaseNet opened this issue 1 year ago • 15 comments

What happened?

It seems since we upgraded to react-native-navigation 7.40.1 and react-native 0.73.9 we are able to click top bar buttons through modals.

clickthrough-topbar-buttons

We used modal presentation style: modalPresentationStyle: Platform.OS === 'ios' ? overFullScreen : overCurrentContext,

What was the expected behaviour?

We should not be able to click through a modal.

Was it tested on latest react-native-navigation?

  • [X] I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

I tried to run the playground project but it has 110 errors compiling typescript...

In what environment did this happen?

React Native Navigation version: 7.40.1 React Native version: 0.73.9 Has Fabric (React Native's new rendering system) enabled: (yes/no) No Node version: 18.19.1 Device model: Android Simulator + Motorola G54 5G Android version: 14

Alberto-BaseNet avatar Oct 22 '24 08:10 Alberto-BaseNet

Seems to be related to ModalPresentationStyle overCurrentContext, I managed to work around by making sure any modal with overCurrentContext (used for transparent background) is fully dismissed before opening any modal on top, if I didn't it would reproduce again.

Alberto-BaseNet avatar Oct 22 '24 11:10 Alberto-BaseNet

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] avatar Jan 31 '25 22:01 stale[bot]

Not stale...

Alberto-BaseNet avatar Feb 05 '25 16:02 Alberto-BaseNet

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] avatar Mar 07 '25 22:03 stale[bot]

Not stale.

Alberto-BaseNet avatar Mar 19 '25 16:03 Alberto-BaseNet

The issue has been closed for inactivity.

stale[bot] avatar Apr 25 '25 20:04 stale[bot]

Not stale

Alberto-BaseNet avatar Apr 29 '25 07:04 Alberto-BaseNet

@gosha212 or @d4vidi can this be reopened?

Alberto-BaseNet avatar May 12 '25 12:05 Alberto-BaseNet

@Alberto-BaseNet We are busy with RN77. Contribution is more than welcomed

gosha212 avatar May 13 '25 10:05 gosha212

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] avatar Jun 26 '25 19:06 stale[bot]

not stale.

Alberto-BaseNet avatar Jun 27 '25 08:06 Alberto-BaseNet

The issue has been closed for inactivity.

stale[bot] avatar Jul 18 '25 18:07 stale[bot]

not stale

Alberto-BaseNet avatar Jul 21 '25 07:07 Alberto-BaseNet

@Alberto-BaseNet is it still reproducible on the latest version of RNN with new arch?

gosha212 avatar Jul 23 '25 07:07 gosha212

We are trying to update to latest RNN and RN 0.77 but are running into https://github.com/wix/react-native-navigation/issues/8026 @gosha212

Alberto-BaseNet avatar Jul 23 '25 08:07 Alberto-BaseNet