react-native-navigation icon indicating copy to clipboard operation
react-native-navigation copied to clipboard

ReactTextShadowNode.UNSET is not available on RN 0.74.1

Open manakuro opened this issue 1 month ago • 7 comments

What happened?

The build failed on Android because of not resolving the symbol ReactTextShadowNode.UNSET on RN 0.74.1 anymore.

        || ((oldStyle & Typeface.BOLD) != 0 && weight == ReactTextShadowNode.UNSET)) {
                                                                            ^
  symbol:   variable UNSET
  location: class ReactTextShadowNode

https://github.com/wix/react-native-navigation/blob/dde5643bba30a32f9c38b9910da2cbc05355342a/lib/android/app/src/main/java/com/reactnativenavigation/utils/ReactTypefaceUtils.java#L99

Since the code was refactored in this PR on 0.74.1, instead of using the ReactTextShadowNode.UNSET, we need to switch it to the ReactConstants.UNSET.

What was the expected behaviour?

The build succeeded.

Was it tested on latest react-native-navigation?

  • [X] I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

Build on RN 0.74.1.

In what environment did this happen?

React Native Navigation version: 7.39.2 React Native version: 0.74.1 Has Fabric (React Native's new rendering system) enabled: no Node version: 20.12.2 Device model: Android version: 14

manakuro avatar May 26 '24 05:05 manakuro