react-native-calendars icon indicating copy to clipboard operation
react-native-calendars copied to clipboard

Fix Expo 53 compatibility and optimize <Agenda> refresh logic

Open edumana opened this issue 9 months ago • 16 comments

Proposed Changes

  1. Expo SDK 53 compatibility
    Fixes a crash that surfaced as Maximum update depth exceeded when using <Agenda> in Expo 53.

  2. Reliable reservation refresh
    <Agenda> now detects a new items reference and re‑renders the reservation data accordingly.

  3. Smoother updates in the underlying FlatList
    Reworked the update logic to avoid clearing and re‑setting state. This removes visual flicker and results in noticeably smoother scrolling.

edumana avatar May 16 '25 13:05 edumana

Hi I upgraded to Expo 53, what can I do to prevent this bug until new version will release? @edumana Thank you :)

rom529 avatar Jun 02 '25 16:06 rom529

hey @rom529 You can set your package.json to use this branch's build like so:

package.json

"react-native-calendars": "https://codeload.github.com/craftworkco/react-native-calendars/tar.gz/ae19e2af74ecdb29d6117ca41fbf41977a10cc23",

edumana avatar Jun 02 '25 16:06 edumana

This works for me on Expo 53. When could we expect an official release?

ssunday avatar Jun 18 '25 13:06 ssunday

Any estimate for when this will be merged? :)

mariusgronli avatar Jun 20 '25 12:06 mariusgronli

Does anyone know when will it be an offical release or will be merged?

sufyansalim avatar Jun 20 '25 15:06 sufyansalim

Using this did fix the error, but Agenda is now not showing up at all on screen. Not sure what to do from here.

ChinazoOnwukaike avatar Jun 24 '25 21:06 ChinazoOnwukaike

Hi Wix team - anything we can do to help get this branch tested and merged?

mbifulco avatar Jun 30 '25 14:06 mbifulco

+1

marijang avatar Jul 01 '25 12:07 marijang

Still happening with latest 1.1313.0, this PR needs some attention please 🙏

simon-musy avatar Jul 01 '25 17:07 simon-musy

any update on this?

dwale avatar Jul 11 '25 13:07 dwale

Any updates on when this could get into a release?

ssunday avatar Jul 24 '25 12:07 ssunday

Excuse, why not merge this PR? Maybe there is any problem or BUG?

cw1997 avatar Aug 01 '25 21:08 cw1997

Sometimes the monthly scrolling list gets stuck and we can't go into like the day view.

ssunday avatar Aug 18 '25 13:08 ssunday

Sometimes the monthly scrolling list gets stuck and we can't go into like the day view.

I also found the BUG, do you have resolved the problem?

cw1997 avatar Sep 11 '25 08:09 cw1997

@cw1997 https://github.com/wix/react-native-calendars/pull/2713 has been working

ssunday avatar Sep 11 '25 13:09 ssunday

same issue on expo 53

cuongleaccess avatar Oct 16 '25 01:10 cuongleaccess