react-native-calendars
react-native-calendars copied to clipboard
Fix/theme issues
Reverted props extraction as they seem to mess with the Theme for the Agenda
Hi is there any way I can test this build ?
Yeah, if you compile the files using "tsc", then use the newly emitted files as a node module, you can test it yourself. They also already have a set of tests prepared, that the docs tell you how to run.
@dlariosuniandes Please describe the bug you wish to solve. Reverting to the previous usage of extractComponentProps
is not recommended for performance. We'll need to find how to fix extractHeaderProps
instead, so please add a description of the bug and a code snippet so we can try to reproduce it.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Are there any plans to address this ? Currently it is impossible to modify a lot of the Theme props for the agenda.
@Saikedo Hi. See the PR #2041
@Inbal-Tish Seems like backgroundColor
is still not working after the PR #2041.
I managed to make it work with reservationsBackgroundColor
but I am not sure if this is appropriate since reservationsBackgroundColor
is not even listed in the Theme.
Am I missing something? Is there a better way of handling this?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.