react-native-calendars icon indicating copy to clipboard operation
react-native-calendars copied to clipboard

Fix/theme issues

Open dlariosuniandes opened this issue 2 years ago • 3 comments

Reverted props extraction as they seem to mess with the Theme for the Agenda

dlariosuniandes avatar Sep 01 '22 18:09 dlariosuniandes

Hi is there any way I can test this build ?

dlariosuniandes avatar Sep 01 '22 18:09 dlariosuniandes

Yeah, if you compile the files using "tsc", then use the newly emitted files as a node module, you can test it yourself. They also already have a set of tests prepared, that the docs tell you how to run.

dasanibroto avatar Sep 03 '22 23:09 dasanibroto

@dlariosuniandes Please describe the bug you wish to solve. Reverting to the previous usage of extractComponentProps is not recommended for performance. We'll need to find how to fix extractHeaderProps instead, so please add a description of the bug and a code snippet so we can try to reproduce it.

Inbal-Tish avatar Sep 04 '22 07:09 Inbal-Tish

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 03 '22 07:12 stale[bot]

Are there any plans to address this ? Currently it is impossible to modify a lot of the Theme props for the agenda.

Saikedo avatar Dec 05 '22 15:12 Saikedo

@Saikedo Hi. See the PR #2041

Inbal-Tish avatar Dec 06 '22 08:12 Inbal-Tish

@Inbal-Tish Seems like backgroundColor is still not working after the PR #2041.

I managed to make it work with reservationsBackgroundColor but I am not sure if this is appropriate since reservationsBackgroundColor is not even listed in the Theme.

Am I missing something? Is there a better way of handling this?

Saikedo avatar Dec 16 '22 18:12 Saikedo

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 18 '23 02:03 stale[bot]