react-native-calendars icon indicating copy to clipboard operation
react-native-calendars copied to clipboard
verified publisher icon wix

Week calendar refactor

Open yuvalsho opened this issue 3 years ago • 1 comments

yuvalsho avatar Aug 07 '22 08:08 yuvalsho

@yuvalsho Can you please check the conflicts and the failing build?

Inbal-Tish avatar Aug 08 '22 11:08 Inbal-Tish

@yuvalsho Hi. Please pull master and resolve conflicts

Inbal-Tish avatar Aug 15 '22 07:08 Inbal-Tish

@yuvalsho Why there are 18 files changed? Can we please keep this PR clean only for the WeekCalendar changes?

Inbal-Tish avatar Sep 04 '22 07:09 Inbal-Tish

@yuvalsho Overall looks and feels good. Just a few comments about this PR's scope and some code standards. Also, I did find some little bugs, not only in the ExpandableCalendarScreen but also in other screens, like WeekCalendarScreen and TimelineCalendarScreen (with 'numberOfDays` passed). Need to make sure we're not breaking anything in the process...

Inbal-Tish avatar Sep 04 '22 10:09 Inbal-Tish

@yuvalsho When passing disableWeekScroll prop the calendar not working properly.

Inbal-Tish avatar Sep 07 '22 06:09 Inbal-Tish

@yuvalsho Hi. Can you please resolve conflict and let's merge this?

Inbal-Tish avatar Sep 18 '22 11:09 Inbal-Tish