playable icon indicating copy to clipboard operation
playable copied to clipboard

The current playground is not enough to contribute into playable

Open rudnitskih opened this issue 5 years ago • 7 comments

During working on RTL feature we found only one way how to test playble in different configurations is change something in develop.ts file. This approach is annouying because is diffuclt to understand all possible configurations for library and make some changes.

I propose to describe all options in playground page.

rudnitskih avatar Sep 18 '19 08:09 rudnitskih

PR - https://github.com/wix/playable/pull/134

rudnitskih avatar Sep 20 '19 13:09 rudnitskih

TODOs:

  • [ ] Better integration with oki-doc (make storybook as subpage of docs site, not external links)
  • [ ] Think about which knobs should be in the playground
  • [ ] Better code architecture for Story

rudnitskih avatar Sep 20 '19 13:09 rudnitskih

Quick intro to storybook: https://storybook.js.org/docs/guides/guide-react/ knobs doc: https://www.npmjs.com/package/@storybook/addon-knobs

rudnitskih avatar Sep 20 '19 13:09 rudnitskih

Unfortunately, after the following npm i some issue with webpack which I don't know how to fix quickly:

image

Will try to take a look on next week.

rudnitskih avatar Sep 20 '19 13:09 rudnitskih

@Dariia Did you have any progress with this on Friday?

rudnitskih avatar Sep 21 '19 09:09 rudnitskih

should be related to https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md#breaking-changes

mykolavlasov avatar Dec 02 '19 11:12 mykolavlasov

I fixed this problem with new API for css-loader.

BrooklynKing avatar Dec 18 '19 16:12 BrooklynKing