future-perfect
future-perfect copied to clipboard
wix
Switched internals to use native Scala's Futures
At the moment we are not get rid of Twitter Util yet. But changed future-perfect internals to use scala's futures. The result converted to Twitter Utils Futures/Promises in order not to break outside dependencies.
@nadav-dav because they're very slow to evolve/respond (took them almost as long as us to move to 2.11)
@pavelme why does the build fail?
@electricmonk According to TravisCI:
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated
but my guess is because of 3 warnings that appeared during the build:
[warn] /home/travis/build/wix/future-perfect/src/main/scala/com/wix/async/AsyncExecution.scala:62: abstract type pattern T is unchecked since it is eliminated by erasure [warn] future.onSuccess { case t: T => [warn] ^ [warn] /home/travis/build/wix/future-perfect/src/main/scala/com/wix/async/Implicits.scala:35: abstract type pattern T is unchecked since it is eliminated by erasure [warn] f.onSuccess { case r: T => [warn] ^ [warn] /home/travis/build/wix/future-perfect/src/main/scala/com/wix/async/Implicits.scala:39: abstract type pattern T is unchecked since it is eliminated by erasure [warn] f.onFailure { case e: T => [warn] ^ [warn] three warnings found
I understand the reason but not yet managed to find workaround.
@pavelme I don’t think these warnings are the reason, unless I’m missing something
-- http://www.shaiyallin.com
On February 9, 2015 at 11:35:59 AM, Pavel Meledin ([email protected]) wrote:
@electricmonk According to TravisCI:
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated
but my guess is because of 3 warnings that appeared during the build:
[warn] /home/travis/build/wix/future-perfect/src/main/scala/com/wix/async/AsyncExecution.scala:62: abstract type pattern T is unchecked since it is eliminated by erasure [warn] future.onSuccess { case t: T => [warn] ^ [warn] /home/travis/build/wix/future-perfect/src/main/scala/com/wix/async/Implicits.scala:35: abstract type pattern T is unchecked since it is eliminated by erasure [warn] f.onSuccess { case r: T => [warn] ^ [warn] /home/travis/build/wix/future-perfect/src/main/scala/com/wix/async/Implicits.scala:39: abstract type pattern T is unchecked since it is eliminated by erasure [warn] f.onFailure { case e: T => [warn] ^ [warn] three warnings found
I understand the reason but not yet managed to find workaround.
— Reply to this email directly or view it on GitHub.
@electricmonk "Locally everything works" (c) All tests passed (in Travis log as well). No more info except these 3 warnings :-( May I ask you to checkout it from my fork (https://github.com/pavelme/future-perfect) and just run it on your machine. If the problem not in these 3 warnings then I even don't know where to dig in. It's actually failed for both Scala versions: 2.10 & 2.11 with the same reason.
But the build still fails on Travis. Can you figure out why the build fails on Travis?
-- http://www.shaiyallin.com
On February 9, 2015 at 11:48:00 AM, Pavel Meledin ([email protected]) wrote:
@electricmonk "Locally everything works" (c) All tests passed (in Travis log as well). No more info except these 3 warnings :-( May I ask you to checkout it from my fork (https://github.com/pavelme/future-perfect) and just run it on your machine. If the problem not in these 3 warnings then I even don't know where to dig in. It's actually failed for both Scala versions: 2.10 & 2.11 with the same reason.
— Reply to this email directly or view it on GitHub.
@electricmonk Could you please do a review and in case everything is ok - merge
i guess we will, it was just under our radar. a bit hectic this week but one of us will take it
