Detox icon indicating copy to clipboard operation
Detox copied to clipboard

Does codepush can get along with Detox?

Open chenop opened this issue 3 years ago • 4 comments

Description

I got no fact base for this claim - but its seems that Im reducing the flakiness factor in my tests if I disable codepush. Also stumble into this StackOverflow Answer.

Is it a known issue? What is your recommendation regarding using codepush with Detox?

Your environment

Detox version: 19.10.0 React Native version: 0.66.4 Node version: 14.19.1 Device model: Iphone 13 OS: Test-runner (select one): jest-circus / jest+jasmine / mocha / other

chenop avatar Aug 30 '22 13:08 chenop

Not aware of this problem TBH

d4vidi avatar Aug 30 '22 19:08 d4vidi

Thanks @d4vidi for responding - one more thing to consider: When an app has a codepush version to download then there will be this extra blink and restart that caused during the replacement of the bundle - do you think it might disrupt and fail a detox test?

chenop avatar Aug 30 '22 19:08 chenop

I think it might disrupt Detox, because it assumes the bundle loading takes place inherently during app launch. Nevertheless, that doesn't mean that Detox cannot fundamentally work with codepush; It sounds like the blindspots are mainly around the use cases where a new bundle is loaded, dynamically.

d4vidi avatar Aug 31 '22 08:08 d4vidi

Right exactly - this important point to take into consideration while running the tests - Thanks!

chenop avatar Aug 31 '22 08:08 chenop

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this repository, read this discussion.

stale[bot] avatar Sep 30 '22 17:09 stale[bot]

The issue has been closed for inactivity.

stale[bot] avatar Oct 08 '22 09:10 stale[bot]