Detox icon indicating copy to clipboard operation
Detox copied to clipboard

feat(iOS): replace fbsimctl with AppleSimUtils for `setLocation`.

Open asafkorem opened this issue 3 years ago • 8 comments

Replace deprecated fbsimctl with AppleSimulatorUtils for setLocation API.

AppleSimUtils setLocation is now working as expected thanks to a workaround introduced in version 0.9.6 and another fix from version 0.9.7.

setLocation API (of ASU) requires from the Simulator app to run on non-headless mode (the Simulator app must be opened).

asafkorem avatar Jul 10 '22 12:07 asafkorem

The error that prevents us from setting the location is now Unable to find application named ‘Simulator’, might happen because the user we're using on our agents doesn't have UI (user "builder"). The Simulator app must be open in order to set the new Simulator location (open -a Simulator is failing).

asafkorem avatar Jul 13 '22 12:07 asafkorem

Fixed

asafkorem avatar Jul 13 '22 15:07 asafkorem

Still need to figure out how we can overcome the fact that we can't open the Simulator app on CI @d4vidi

asafkorem avatar Jul 13 '22 15:07 asafkorem

Update: fb/idb's (formerly fbsimctl) set-location API is not working on headless (without open GUI) Simulator mode as well.

asafkorem avatar Jul 17 '22 20:07 asafkorem

@asafkorem can we get this released?

jpbalo avatar Jul 28 '22 02:07 jpbalo

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For more information on bots in this reporsitory, read this discussion.

stale[bot] avatar Sep 08 '22 16:09 stale[bot]

The issue has been closed for inactivity.

stale[bot] avatar Sep 16 '22 00:09 stale[bot]

Not stale, I think we should get back to this PR soon 🙂

asafkorem avatar Sep 18 '22 08:09 asafkorem

Hi !

Not sure how helpful there is, but here's how I'm getting the location to work on IOS (headless mode) Just dropping this here in case of ! If it doesn't help here, it might help people who are waiting for this PR i guess :D

Capture d’écran 2022-10-04 à 08 48 42

Alaa-Ben avatar Oct 04 '22 06:10 Alaa-Ben

Hi !

Not sure how helpful there is, but here's how I'm getting the location to work on IOS (headless mode) Just dropping this here in case of ! If it doesn't help here, it might help people who are waiting for this PR i guess :D

Capture d’écran 2022-10-04 à 08 48 42

Thanks @Alaa-Ben! Sounds like a great contribution to Detox, if you'd like to take that to a PR.

asafkorem avatar Oct 18 '22 11:10 asafkorem

Sure ! + I use idb which is very reliable as it's used at facebook. I'll try to get started on this ASAP 😄

Alaa-Ben avatar Oct 18 '22 12:10 Alaa-Ben

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For more information on bots in this repository, read this discussion.

stale[bot] avatar Dec 15 '22 23:12 stale[bot]

The issue has been closed for inactivity.

stale[bot] avatar Dec 23 '22 15:12 stale[bot]