Detox
Detox copied to clipboard
fix (android): for #3440 - Missing Proguard Entry for org.apache.commons.lang3.**
Missing proguard entry in Detox for lang3.stringutils break method invocation. As multiple lang3 classes are are in detox, I used **
Description
- This pull request addresses the issue described here: #3440
In this pull request, I have added the missing proguard entry to get Detox working again.
For features/enhancements:
- [N/A] I have added/updated the relevant references in the documentation files.
For API changes:
- [N/A] I have made the necessary changes in the types index file.
@jonathanmos can you take it?
I got this, thanks
@d4vidi - Sorry - I'm not following on the first part. I believe I did make the change to: detox/android/detox/proguard-rules-app.pro. Currently my app won't build without the addition of -keep class org.apache.commons.lang3.** { *; }, so it doesn't seem to be automatically added if that's what you mean?
In the meantime I'll get org.apache.commons.io.** added and do a few test builds :)
You added that to proguard-rules-app.pro, I was asking whether you could switch it to proguard-rules.pro. Subtle, I know, but there is a difference 😄
Got it! Not sure how I missed that, hehe! I've made the change locally and will update once I've confirmed everything is building correctly
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For more information on bots in this reporsitory, read this discussion.
Not stale. Planning on reiterating that.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For more information on bots in this reporsitory, read this discussion.
The issue has been closed for inactivity.