Detox icon indicating copy to clipboard operation
Detox copied to clipboard

Return more information in .getAttributes()

Open noomorph opened this issue 3 years ago • 9 comments

@asafkorem says in https://github.com/wix/Detox/pull/3009:

Just to point out, it seems like there are more attributes that we can provide with this API (see https://reactnative.dev/docs/accessibility), like accessibilityHint, or accessibilityState.. Sure, out of this PR scope. I'm talking about a change that requires both Android and iOS implementations.

@asafkorem, could you elaborate on this, please? Don't hesitate to change the initial issue description or title if necessary.

noomorph avatar Nov 29 '21 17:11 noomorph

Taking a look at the iOS implementation, it seems that we can simply provide more UIView's attributes, specifically of accessibility information (apple docs) like the mentioned accessibilityHint, or accessibilityState .. I didn't looked at the Android code but there's no reason that we won't have these attributes easily accessible.

This will allow us to be correlated with RN's accessibility properties (https://reactnative.dev/docs/accessibility).

asafkorem avatar Nov 29 '21 20:11 asafkorem

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

stale[bot] avatar Dec 29 '21 22:12 stale[bot]

The issue has been closed for inactivity.

stale[bot] avatar Jan 06 '22 00:01 stale[bot]

@asafkorem @noomorph let's reiterate. This sounds like it should be reopened.

d4vidi avatar Jan 19 '22 20:01 d4vidi

Also relevant: https://github.com/wix/Detox/issues/3203 (see my comment).

asafkorem avatar Feb 03 '22 11:02 asafkorem

Also, accessibilityRole (and probably accessibilitySubrole) could definitely be also relevant while we're at it (as suggested in #3301).

d4vidi avatar Apr 10 '22 12:04 d4vidi

It's still a useful feature, even in 2023, any plans of supporting this feature soon?

Sumit2202 avatar Dec 08 '22 19:12 Sumit2202

Yes, please! I am running into the issue as noted in #3203

RayOei avatar Feb 08 '24 09:02 RayOei

I don't see us taking this in the near future. We could definitely use contributions.

d4vidi avatar Feb 08 '24 16:02 d4vidi