Detox icon indicating copy to clipboard operation
Detox copied to clipboard

(WIP) Replace fbsimctl with AppleSimUtils' setLocation

Open d4vidi opened this issue 3 years ago • 2 comments

Description

Integrate new location API in AppleSimUtils, and with that - eliminate the last usage of fbsimctl, and thus remove it as a dependency.

  • [x] In the process, need to clean location related e2e test from specific refs to fbsimctl, and thus make it always runnable.
  • [ ] Warn about running in headless mode (where setLocation doesn't work)

Related to #1371

d4vidi avatar Apr 14 '21 08:04 d4vidi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

stale[bot] avatar May 14 '21 13:05 stale[bot]

https://github.com/MobileNativeFoundation/set-simulator-location is a good option for setting location on iOS simulators (not sure if it works on real devices). Could use this instead of fbsimctl?

KatieSnell-TomTom avatar Jun 28 '21 09:06 KatieSnell-TomTom

Consider integrating idb, for the headless mode

d4vidi avatar Oct 24 '22 11:10 d4vidi

Once we'll upgrade the mac agents on our internal CI with Xcode 14, we should use simctl new location feature. https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes

simctl now supports controlling simulated location, including running scenarios and interpolating between a list of waypoints. See xcrun simctl location for more information. (59422559) (FB7577924)

asafkorem avatar Feb 14 '23 08:02 asafkorem

@asafkorem since we're making changes to our mac agents regardles... do you think we could apply simctl soon?

d4vidi avatar Jun 14 '23 19:06 d4vidi

+1 on this, it seems that it is difficult to install fbsimctl so would be good to migrate

TheRealNate avatar Jul 07 '23 01:07 TheRealNate

i'm not able to install fbsimctl. How can i run the tests with "SetLocation" without it?

felipejoribeiro avatar Oct 13 '23 12:10 felipejoribeiro

I'll speak to Asaf and see if we can add this to the next team sprints after Detox 21 release.

noomorph avatar Oct 13 '23 13:10 noomorph

Resolved with Detox v20.16. Migrated to Simctl.

asafkorem avatar Jan 14 '24 10:01 asafkorem