vscode-glean
vscode-glean copied to clipboard
wix-incubator
Suggestion: rename "stateful" and "stateless" to class and function respectively
Thanks for this amazing project!
Quick suggestion: could we rename "stateful" and "stateless" to class and function respectively? Rationale:
There are function and class components. Both can be stateful or stateless but that’s an implementation detail.
As per https://mobile.twitter.com/dan_abramov/status/1057625147216220162
Hey @OliverJAsh ! I've also noticed that tweet, and I agree completely. Always hated those terms, but they were better known within the community and they also fit the terms used in Typescript types definition for React.
Care for a PR? I'd love to assist/split the work. Basically, the change involves
- Changing the labels
- Renaming variables and functions within the codebase
- Changing filenames
- Updating the docs
I noticed this as well. Just set a reminder for myself on Jan 2nd after the holidays to see if this is still open. If so, I'll try and find some time to submit the PR. 😃
@itzsaga awesome! I'd love to assisst and point you in the right direction!
@borislit, back! Ready to be pointed in the right direction 😃 outside of just a project search for the two strings.
@itzsaga hey! Thanks for the initiative :) Ill create a list for ya later tonight :)
Hey @itzsaga ! Sorry for not getting back to You! I was busy working on the Hooks support. Now that its here, This change makes ALOT of sense. Later tonight ill point out the places We'll need to change