commons-validator-js

commons-validator-js copied to clipboard

-1 star since it doesn't implement url-validator

4

3LOK

BnayaZil

ASCII Control characters inside the email are not failing the validation: ASCII control characters: https://www.december.com/html/spec/ascii.html The regex to try: `/[^\x00-\x1F]/.test(email)` `expect(validator.isValid('joeblow @apache.org')).toBeFalsy();` // passes (as expected) `expect(validator.isValid('joeblow@apache.org')).toBeFalsy();` // fails `expect(validator.isValid('joeblow\[email protected]')).toBeFalsy();`...

anlesk

releases being cut daily despite lack of code change

2

it looks like your CI may have run away with itself, and there's currently a release occuring every day regardless of whether the code has changed or not (for reference,...

hauntingEcho

move wnpm-ci and bower-auto-release to devDependencies

1

currently, these two dependencies are only being used in build scripts. However, parsing projects (in particular [WebJars](https://www.webjars.org/)) can't say with certainty that they're unneeded as-is. Moving them to devDependencies will...

hauntingEcho

currently, the CI builder is not committing its `package.json` transformations back to the repository, causing the file to be out-of-sync with the version released to npm.

hauntingEcho