angular-tree-control icon indicating copy to clipboard operation
angular-tree-control copied to clipboard

No minified versions of JS / CSS in bower package

Open drew-r opened this issue 9 years ago • 5 comments

Pretty self explanatory really :) Would be great to get one included in the bower package.

drew-r avatar Mar 08 '15 23:03 drew-r

To my understanding, bower guidelines are that minified versions should not be included in package. Rather, you should create your versions in your build process. On Mar 9, 2015 1:26 AM, "Drew R" [email protected] wrote:

Pretty self explanatory really :) Would be great to get one included in the bower package.

— Reply to this email directly or view it on GitHub https://github.com/wix/angular-tree-control/issues/113.

yoavaa avatar Mar 08 '15 23:03 yoavaa

Bower spec does say this but almost all widely used libraries include one for convenience... JQuery, AngularJS, Blanket, Bootstrap, D3.js etc.

On Sun, Mar 8, 2015 at 11:39 PM, Yoav Abrahami [email protected] wrote:

To my understanding, bower guidelines are that minified versions should not be included in package. Rather, you should create your versions in your build process. On Mar 9, 2015 1:26 AM, "Drew R" [email protected] wrote:

Pretty self explanatory really :) Would be great to get one included in the bower package.

— Reply to this email directly or view it on GitHub https://github.com/wix/angular-tree-control/issues/113.

— Reply to this email directly or view it on GitHub https://github.com/wix/angular-tree-control/issues/113#issuecomment-77782341 .

drew-r avatar Mar 08 '15 23:03 drew-r

That's been discussed multiple times on the issue tracker, and the consensus is that JS in Bower packages should be built, but not minified. The simple reason being that most will minify them in their build step anyways, and having both bloats the package and complicates everything.

Kepro avatar Nov 20 '15 16:11 Kepro

@Kepro I call copypasta

drew-r avatar Jan 29 '16 10:01 drew-r

Since bower is deprecated now, i think it is time to move on from this (IMHO) stupid rule. This is the only dependency i have, that needs to be minified by my build process.

Not providing a minified version leads to bloated build processes and possible problems for the users

MichaelFroeschen avatar Mar 12 '18 09:03 MichaelFroeschen