wittlock
fix getBoundingClientRect error in ssr applications
Added condition to skip the dom api call getBoundingClientRect() on server. This change fixes #63
There's some conflict between this pr and a recently merged one. If you update it I'd be happy to test and merge this one too.
Closing this due to lack of progress. Feel free to open a new one if interest resurfaces.
You have not been able to fix a conflict in 8 lines of code? Please go a head merging this fix or provide a solid SSR fix solution. @urohith173 don't you follow this topic anymore?
I am not following the repo currently. that's why i couldn't reply to the comments. @DDurakISH thanks for bringing it to my attention by tagging me i will look into the conflicts and create a new pr.
@DDurakISH @wittlock no new pr is required as the current code in master branch will not result in this issue.
Note: the issue still exists in the current latest version 2.1.0. So the next release should fix it.
I'll try and send out a release this weekend from master. It'll probably be a major version release as it's a big refactoring and could break. I'll post here when it's out.
On Fri, Oct 27, 2023, 10:12 urohith173 @.***> wrote:
Note: the issue still exists in the current latest version 2.1.0. So the next release should fix it.
— Reply to this email directly, view it on GitHub https://github.com/wittlock/ngx-image-zoom/pull/76#issuecomment-1782489022, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGGNQKYEZ75ACYPOLSA6TYBNUFBAVCNFSM4UGN7CWKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZYGI2DQOJQGIZA . You are receiving this because you were mentioned.Message ID: @.***>
Alright. Weekend got away from me, but now there's a 3.0.0 up at npm. I hope this works as expected and sorts your ssr related issues. Let me know if there's anything wonky with it.