ngx-image-zoom icon indicating copy to clipboard operation
ngx-image-zoom copied to clipboard

Support on ChangeDetection-Strategy OnPush

Open cice opened this issue 4 years ago • 1 comments

Could also possibly fix https://github.com/wittlock/ngx-image-zoom/issues/36

We have ngx-image-zoom embedded in an OnPush component and apparently this is not supported (at least it stopped working with Ivy / NG9).

This is a work in progress, open for discussion. I did not dive deep into the code, just needed a quick fix for our app.

I published this branch on NPM as @zeit-dev/ngx-image-zoom, v0.6.1 if anybody would like to try. Cheers Marian

PS: To replace the original ngx-image-zoom with @zeit-dev/ngx-image-zoom don't forget to remap the path in tsconfig.json:

{
  "compilerOptions": {
    ...,
    "paths": {
      "ngx-image-zoom": ["node_modules/@zeit-dev/ngx-image-zoom"]
    }
  },
  ...
}

cice avatar Mar 16 '20 16:03 cice

Any plans on working further on this one?

wittlock avatar Apr 28 '22 15:04 wittlock

Closing this due to lack of progress. Feel free to open a new one if interest resurfaces.

wittlock avatar Apr 15 '23 18:04 wittlock