ngx-image-zoom icon indicating copy to clipboard operation
ngx-image-zoom copied to clipboard

Image tag is changed to picture tag

Open garybarzola opened this issue 1 year ago • 4 comments

  • The picture tag is currently compatible with all browsers and allows progressive image loading according to the available internet conditions and screen sizes.

garybarzola avatar Oct 06 '23 22:10 garybarzola

Great, really good solution and upgrade. It will help a lot!

danigandarillas avatar Oct 13 '23 21:10 danigandarillas

This should be in the repo as a feature @wittlock

ernestoliberio avatar Oct 13 '23 21:10 ernestoliberio

I'm not personally familiar with the picture tag and it's compatibility. It seems fairly well adapted looking at caniuse.com - but I'd be a bit worried swapping a core tag like this out just like that. Could this maybe be adjusted to be an alternative template with an opt-in setting to use it?

wittlock avatar Oct 31 '23 18:10 wittlock

Of course it works just as you describe, that's the great thing about this picture tag. I have added two alternative inputs: thumbImageSource and fullImageSource, which if added would complete the functionality of the picture tag and if not added would work as it has been working with the thumbImage and fullImage inputs.

@wittlock

garybarzola avatar Nov 09 '23 21:11 garybarzola