studiocms icon indicating copy to clipboard operation
studiocms copied to clipboard
Published 1 week ago • verified publisher icon withstudiocms

Add light mode to the main landing page

Open jdtjenkins opened this issue 1 year ago • 10 comments

Is your feature request related to a problem? Please describe. So there seems to only be a light more for some parts of the landing page. It'd be great to get the whole thing with a light mode!

Describe the solution you'd like Adding global variables for our light mode colours and make sure we're explicitly calling dark:... for our dark theme.

Additional context We're using Tailwind v3 on the landing page, so it should be easy enough to extend Tailwind properly and get the light/dark mode all working correctly.

image

jdtjenkins avatar May 03 '24 07:05 jdtjenkins

Hi, I Would like to work on this issue can you assign me this issue for contribution

anmol-fzr avatar May 13 '24 13:05 anmol-fzr

Hey @anmol-fzr, thanks for showing interest on this one. I will assign it to you.

dreyfus92 avatar May 13 '24 15:05 dreyfus92

Branch issue-0049 created for issue: Add light mode to the main landing page

create-issue-branch[bot] avatar May 13 '24 15:05 create-issue-branch[bot]

@dreyfus92 Hi, Should i change theme to light mode or i have to add a theme toggle switch ?

anmol-fzr avatar May 14 '24 14:05 anmol-fzr

Hey @anmol-fzr, you can use this resource as reference, we'd like a toggle button to handle this.

dreyfus92 avatar May 14 '24 16:05 dreyfus92

Also as a side note, when we assign an issue to who ever is interested in working we have a bot that auto generates a branch and links the issue to it. So would you mind pushing the change of the current branch you're working on to this one instead? https://github.com/astrolicious/studiocms/pull/81

dreyfus92 avatar May 14 '24 16:05 dreyfus92

Hey everyone 👋 , I will kickstart this issue in #81 in the mean time I believe Create-Issue-Branch(CIB) bot needs to assign this issue to me because without it I don't receive perms to push/pull 🤔 and all my changes go into a fork

at-the-vr avatar May 17 '24 06:05 at-the-vr

Thanks for jumping in @at-the-vr 🫡

dreyfus92 avatar May 17 '24 07:05 dreyfus92

@Adammatthiesen for some reason the bot hasn't pinged or auto assigned this to Atharva yet in the PR, are you able to assign it to him within the PR?

dreyfus92 avatar May 17 '24 08:05 dreyfus92

@Adammatthiesen for some reason the bot hasn't pinged or auto assigned this to Atharva yet in the PR, are you able to assign it to him within the PR?

He has been added to Revered and is now assigned to the PR :)

Adammatthiesen avatar May 17 '24 08:05 Adammatthiesen