draft-js-markdown-plugin icon indicating copy to clipboard operation
draft-js-markdown-plugin copied to clipboard

DraftJS v0.11.x Support

Open thecodedrift opened this issue 5 years ago • 1 comments

Fixes #181

To support DraftJS v0.11.x forward, handleBeforeInput needs to take an additional parameter eventTimestamp for synchronizing collaborative actions. This change adds support for eventTimestamp, updates all tests and snapshots, and updates the peerDependencies to match.

Contains stylistic changes triggered by saving with a .prettierrc. Since it was complaining in vscode, I also fixed the singleQuote property to match the intended value from the prettier docs.

BREAKING CHANGE: The changes to DraftJS and draft-js-plugin-editor are not backwards compatible with the 0.10.x/2.0.0 versions respectively. The peerDependencies were updated to reflect this and a note was added to the readme.

note: this PR is intentionally in smaller commits for the purpose of more efficient rebasing. At owner's request, I'm happy to squash these down to a single commit on approval & before merge. ❤️

thecodedrift avatar Feb 05 '20 18:02 thecodedrift

nice

but it'd be easier to review if you removed all the random formatting changes. For anyone who is curious, there fix is just a small change which adds a single variable to the parameter list of handleBeforeInput

tantaman avatar Aug 15 '20 17:08 tantaman