danger-plugin-labels icon indicating copy to clipboard operation
danger-plugin-labels copied to clipboard
verified publisher icon withspectrum

Doesn't properly remove labels

Open mxstbr opened this issue 7 years ago • 1 comments

Repro:

screen shot 2018-06-13 at 13 20 54

  1. Tick "WIP"
  2. Do some work
  3. Edit comment to untick "WIP" and tick "Ready for Review"
  4. The bot doesn't remove the old label

mxstbr avatar Jun 13 '18 11:06 mxstbr

I believe this bug comes from this line in uncheckedLabels reducer

    return [...labels, label]

the expected result of the repro for the code to work the "WIP" checkbox should match the label exactly, otherwise, the filter of current labels will not find the "WIP: Building"

Shouldn't it be rules.label instead?

Edit 1: worked just fine in my tests just now, so no clue no more, lol maybe close the issue?

thlmenezes avatar Aug 12 '22 15:08 thlmenezes