failure_derive icon indicating copy to clipboard operation
failure_derive copied to clipboard

Dependencies are out-of-date causing dependent packages to build them twice

Open briansmith opened this issue 6 years ago • 5 comments

Currently Cargo.toml has:

[dependencies]
quote = "0.3.15"
syn = "0.11.11"
synstructure = "0.6.0"

Other libraries my project depends on require:

  • quote 0.4.2
  • syn 0.12.10

It would be great if failure_derive could pick up those new versions so that dependent projects like mine don't have to download and compile multiple versions of these packages.

I attempted to do this by updating Cargo.toml like so:

 [dependencies]
-quote = "0.3.15"
-syn = "0.11.11"
-synstructure = "0.6.0"
+quote = "0.4.2"
+syn = "0.12.13"
+synstructure = "0.7.0"

However, this broke the build. Unfortunately I don't know enough about writing macros using syn and quote to fix this myself.

briansmith avatar Feb 27 '18 03:02 briansmith

I'm into it. They've changed some stuff in syn in that 11->12 update, hopefully I'll be able to migrate the code without hitting any major problems.

If somebody works on that already please ping me so we don't do the same job twice (or thrice or ...).

mexus avatar Mar 05 '18 23:03 mexus

There's an open PR already in rust-lang-nursery/failure#179

withoutboats avatar Mar 05 '18 23:03 withoutboats

Oh boy. Thanks for mentioning!

mexus avatar Mar 05 '18 23:03 mexus

There's an open PR already in rust-lang-nursery/failure#179

What is the status of this repo (withoutboats/failure_derive) to that one (rust-lang-nursery/failure)? Is rust-lang-nursery/failure replacing this one?

briansmith avatar Mar 06 '18 01:03 briansmith

Yea, this code was moved into the main repo. I'll shut this repo down once failure 1.0 is released.

withoutboats avatar Mar 06 '18 01:03 withoutboats