Rob Landers comments

Results 541 comments of


                                            Rob Landers

FrankenPHP compiled against shared libphp.so reports version at compile time, not loaded version.

> But libphp.so was updated to 8.4.7. FrankenPHP reports the version it was compiled against, not the one that is actually being loaded. That may cause issues since PHP doesn't...

FrankenPHP compiled against shared libphp.so reports version at compile time, not loaded version.

"should" and "will" are quite different. The former implies "in most cases" while the latter suggests "always".

FrankenPHP compiled against shared libphp.so reports version at compile time, not loaded version.

FrankenPHP doesn’t make extensive use of the PHP ABI, so it can change pretty drastically unless someone modifies the SAPI struct or one of the functions FrankenPHP calls. This is...

FrankenPHP compiled against shared libphp.so reports version at compile time, not loaded version.

There was an ABI break in 8.2.x to 8.2.y (IIRC, and I may not be. It was a long time ago.) — that was my point. It isn’t guaranteed to...

FrankenPHP compiled against shared libphp.so reports version at compile time, not loaded version.

Maybe, instead of outputting the full version of 8.x.y, we only output 8.x?

FrankenPHP compiled against shared libphp.so reports version at compile time, not loaded version.

So, - output major/minor version in the version string - if major/minor version doesn't match what it was compiled with: issue a warning ?? note: static compiles probably want to...

FrankenPHP compiled against shared libphp.so reports version at compile time, not loaded version.

> I was never able to call any php code without causing a segfault before Start() finished. I don't know how to even get the dynamically loaded version. One option...

Build mostly static frankenphp linking against only libphp.so (and libc.so)

> But I also didn't know how to properly introduce the php version it's linking against in the version. Names are easy to change. It may be annoying, but if...

fix: add `jq`, `git`, `unzip` and `curl` to default packages installed

Will also fix https://github.com/actions/actions-runner-controller/issues/3222

fix: add `jq`, `git`, `unzip` and `curl` to default packages installed

There's probably some huge philosophical debate behind closed doors: - the practical: yeah, this makes sense - the minimalist: they'd have it be a clone of `scratch` if they could...