graphite-cli icon indicating copy to clipboard operation
graphite-cli copied to clipboard

Support GitHub Enterprise Server

Open darthwalsh opened this issue 2 years ago • 1 comments

It's unclear to me whether gt CLI (or app.graphite.dev) should support GitHub Enterprise Server (GHES) pull requests, instead of only supporting github.com.

i.e. gt stack submit worked fine on my github.com repo, but if I use it on an internal GHES repo:

$ git remote -v
origin	[email protected]:MyOrg/team-repo.git (fetch)
origin	[email protected]:MyOrg/team-repo.git (push)
$ gt stack submit
✏️  [Step 1] Validating that this Graphite stack is ready to submit...
Validation for current stack: passed

ERROR: Failed to infer the owner and name of this repo from remote origin "[email protected]:MyOrg/team-repo.git". Please run `gt repo owner --set <owner>` and `gt repo name --set <name>` to manually set the repo owner/name. (e.g. in the repo 'withgraphite/graphite-cli', 'withgraphite' is the repo owner and 'graphite-cli' is the repo name)

If you'll take the feature request, supporting GHES in the CLI could look like how the official GitHub gh CLI login flow, and if needed overriding the GHES host with the GH_HOST env var.


For now if the feature isn't supported, it would be nice to mention that at some docs pages; here's a few I clicked through hoping for an answer:

  • https://docs.graphite.dev/guides/graphite-cli/authenticating-the-cli
  • https://docs.graphite.dev/guides/graphite-dashboard/getting-started-with-the-dashboard
  • https://grafana.com/docs/grafana/latest/enterprise/

darthwalsh avatar Apr 28 '22 17:04 darthwalsh

We don't currently support GHES, although we plan on building support down the line! Thanks for the ideas about the login flow and GH_HOST env var!

goldjacobe avatar Jun 15 '22 03:06 goldjacobe