fig icon indicating copy to clipboard operation
fig copied to clipboard

Fig does not work in VSCODE when in Remote SSH server.

Open mikebronner opened this issue 1 year ago • 9 comments

Sanity checks

  • [X] I have searched github.com/withfig/fig/issues and there are no duplicates of my issue
  • [X] I have run fig doctor in the affected terminal session
  • [X] I have run fig restart and tested again (tell us if that fixed it)

Issue Details

  • Fig works great when in VSCode when developing locally
  • Fig does not appear to work (no autocomplete) when developing on a Remote SSH server
  • Fig does work on the remote server when using SSH in a normal mac terminal

Environment

### Details:
|OS|Fig|Shell|
|-|-|-|
|Linux 5.4.0-122-generic||/usr/bin/zsh|
fig diagnostic

# Fig Diagnostics
## NOTE: Fig is not running, run `fig launch` to get the full diagnostics
## Fig details:
## Hardware Info:
  - Model Name: cpu0
  - Model Identifier: GenuineIntel
  - Chip: Intel(R) Xeon(R) Platinum 8168 CPU @ 2.70GHz
  - Cores: 8
  - Memory: 16786022 KB
## OS Info:
  - Linux 5.4.0-122-generic
## Environment:
  - User Shell: Unknown UserShell
  - Current Directory: /home/forge/mike-b.totalitylms.com
  - CLI Installed: true
  - Executable Location: /home/forge/.local/bin/fig
  - Current Window ID: <unknown>
  - Active Process: <unknown>
  - Terminal: vscode
  - Environment Variables:
    - FIG_PID=4070615
    - PATH=/home/forge/.vscode-server-insiders/bin/eebdf8174b087979ae6af103f6f2e2f6f9062056/bin/remote-cli:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/forge/.local/bin:/home/forge/.fig/bin:/home/forge/.config/composer/vendor/bin:/home/forge/.config/composer/vendor/bin
    - TERM=xterm-256color
## Integrations:

mikebronner avatar Aug 13 '22 15:08 mikebronner

Hmmm. My hunch is this is because remote VSCode terminals are spawned with SSH as the main process, rather than a local bash/zsh process and then running SSH.

Fig requires the local bash/zsh process to get your cursor position...

To confirm this suspicion, if you run exit while SSHd into a remote machine does it quit the terminal entirely or just throw you into a local shell session?

brendanfalk avatar Aug 15 '22 18:08 brendanfalk

Interesting problem though, @sullivan-sean any ideas?

brendanfalk avatar Aug 15 '22 19:08 brendanfalk

To confirm this suspicion, if you run exit while SSHd into a remote machine does it quit the terminal entirely or just throw you into a local shell session?

When running exit from within VSCODE it completely quits the terminal.

mikebronner avatar Aug 15 '22 19:08 mikebronner

Interesting problem though, @sullivan-sean any ideas?

I suspect you might see more of this issue, as more people start using GitHub Codespaces. We're working on transitioning from RemoteSSH to Codespaces.

mikebronner avatar Aug 15 '22 19:08 mikebronner

Interesting problem though, @sullivan-sean any ideas?

This should be fixed by our v2 SSH solution (coming in the next few days) that will also fix things like, e.g. fig in tmux in SSH. For now I think this is not expected to work, as Fig's current solution requires a local TTY as the parent of the running ssh process

sullivan-sean avatar Aug 16 '22 19:08 sullivan-sean

@sullivan-sean you mentioned above that this might have been addressed in SSHv2 ... has that been released? Just following up to see what the expectation is, as it is currently still not working for me. Thanks :)

mikebronner avatar Dec 06 '22 18:12 mikebronner

It seems like there's a bug in our latest build with SSH v2 but I've got a fix for this coming in the next build.

I've tested the new integration with VSCode remote and the expectation (post-fix) is that Fig should be working. I'll post an update here when the new build is live and you can let me know if you're still having issues getting it setup!

sullivan-sean avatar Dec 06 '22 21:12 sullivan-sean

Hi all, just wanted to ask if there’s any update on this issue? I extensively use vscode remote ssh and would love to enable fig in the integrated terminal.

benjiebob avatar Sep 07 '23 08:09 benjiebob

Related to #2656

oskar-gmerek avatar Feb 13 '24 23:02 oskar-gmerek