autocomplete icon indicating copy to clipboard operation
autocomplete copied to clipboard

feat: Add ddev spec for DDEV

Open khalwat opened this issue 3 years ago • 2 comments

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Spec addition: ddev for the DDEV local development environment

What is the current behavior? (You can also link to an open issue here)

Currently ddev is not available

What is the new behavior (if this is a feature change)?

Adds the ddev spec

Additional info:

Leverages the Fig-provided Cobra module for generating the spec directly from the ddev command: https://github.com/drud/ddev/pull/4216

khalwat avatar Sep 21 '22 19:09 khalwat

Overview

src/ddev.ts:

Info:

withfig-bot avatar Sep 21 '22 19:09 withfig-bot

Hello @khalwat, thank you very much for creating a Pull Request! Here is a small checklist to get this PR merged as quickly as possible:

  • [ ] Do all subcommands / options which take arguments include the args property (args: {})?
  • [ ] Are all options modular? E.g. -a -u -x instead of -aux
  • [ ] Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

withfig-bot avatar Sep 21 '22 19:09 withfig-bot

Looks good! Can you run npm run lint:fix to fix the linting errors?

clo4 avatar Sep 22 '22 05:09 clo4

Done. FWIW, the output here is coming directly from your own Cobra tool:

https://fig.io/docs/guides/integrating/integrations/cobra

...so if what it outputs isn't passing linting, probably it should be fixed as well?

khalwat avatar Sep 22 '22 06:09 khalwat

Agreed! It's not a huge deal because the linting errors can be fixed automatically and will be fixed when using our push to autocomplete CI action, but agreed, it should be as close as possible to the intended output by default.

clo4 avatar Sep 22 '22 06:09 clo4

cc @fedeci

clo4 avatar Sep 22 '22 06:09 clo4

If there's anything else you need me to do here, just let me know.

khalwat avatar Sep 22 '22 20:09 khalwat

How does it work in terms of an actual release that will be available for people to use?

khalwat avatar Sep 23 '22 13:09 khalwat

@khalwat specs are automatically published once they are merged in but, because of caches (npm registry and our CDN provider), they often need a couple days before being publicly available.

fedeci avatar Sep 24 '22 06:09 fedeci