autocomplete icon indicating copy to clipboard operation
autocomplete copied to clipboard

feat: add `go-task` spec

Open yoavbls opened this issue 3 years ago • 3 comments

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) feature, add spec for go-task

What is the current behavior? (You can also link to an open issue here) Currently, fig shows autocompletion only for taskwarrior binary when writing task ...

What is the new behavior (if this is a feature change)? fig will show autocompletion for go-task if it is the binary that runs on task, or taskwarrior if it isn't

CleanShot 2022-03-19 at 19 18 36@2x

Additional info: Unfortunately, autocompletion appears also when writing go-task ... or taskwarrior ... I would like to know about a way to disable it, I can't use loadSpec because it doesn't work for root commands (#223)

yoavbls avatar Mar 19 '22 17:03 yoavbls

Overview

src/task/taskwarrior.ts:

Info:

Single Functions:

script:

 function () {
    return `task export`;
  }

script:

 function (context) {
    return `task export`;
  }

script:

 function (context) {
    return `task export`;
  }

script:

 function (context) {
    return `task export`;
  }

URLs:

  • https://f-droid.org/repo/icons-640/kvj.taskw.3.png

src/task.ts:

Info:

src/task/go-task.ts:

Info:

URLs:

  • https://taskfile.dev/favicon.ico

withfig-bot avatar Mar 19 '22 17:03 withfig-bot

Hello @yoavbls, thank you very much for creating a Pull Request! Here is a small checklist to get this PR merged as quickly as possible:

  • [ ] Do all subcommands / options which take arguments include the args property (args: {})?
  • [ ] Are all options modular? E.g. -a -u -x instead of -aux
  • [ ] Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

withfig-bot avatar Mar 19 '22 17:03 withfig-bot

Additional info: Unfortunately, autocompletion appears also when writing go-task ... or taskwarrior ... I would like to know about a way to disable it

I still have to review this PR but you can nest taskwarrior.ts and go-task.ts under a directory e.g. task/taskwarrior.ts, task/go-task.ts

fedeci avatar Mar 19 '22 18:03 fedeci

@fedeci or @mschrage could we please review and merge this PR?

I have run into this exact issue recently and popped over to investigate/fix it only to find that @yoavbls has already fixed it! 😍

I just checked out this branch locally, ran the autocomplete specs in dev mode, and verified that this PR does in fact replace the taskwarrior autocompletions with the tasks from my taskfile. 🎉

davidalpert avatar Feb 13 '23 00:02 davidalpert

I am giving a look @davidalpert! @yoavbls can you please accept the CLA?

fedeci avatar Feb 13 '23 18:02 fedeci

@fedeci where do I accept it? Do you want me to resolve the conflicts? Is someone going to review it?

yoavbls avatar Feb 13 '23 18:02 yoavbls

@yoavbls I am reviewing right now, don't worry about conflicts, I am fixing those! Sorry for late feedback!

fedeci avatar Feb 13 '23 18:02 fedeci

recheck

fedeci avatar Feb 13 '23 18:02 fedeci

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

withfig-bot avatar Feb 13 '23 18:02 withfig-bot

I have read the CLA Document and I hereby sign the CLA

yoavbls avatar Feb 13 '23 18:02 yoavbls