starlight icon indicating copy to clipboard operation
starlight copied to clipboard
verified publisher icon withastro

Select options are not centrally aligned

Open jermanuts opened this issue 1 year ago • 2 comments

What version of starlight are you using?

0.19.1

What version of astro are you using?

4.4.4

What package manager are you using?

pnpm

What operating system are you using?

Windows

What browser are you using?

Brave

Describe the Bug

This is how they look

image

They should look like that

image

Same with the language selection box

image image

Link to Minimal Reproducible Example

https://github.com/withastro/starlight

Participation

  • [ ] I am willing to submit a pull request for this issue.

jermanuts avatar Feb 23 '24 21:02 jermanuts

this feels like a subjective opinion and less of a bug (both look fine to me). Could you share a concrete proof in form of a reference from MDN or a trusted article talking that your suggestions are applicable?

at-the-vr avatar Feb 24 '24 18:02 at-the-vr

I would agree with a little bit more margin to the left side of the label icon. That's used by Material UI for example: https://m2.material.io/components/menus#exposed-dropdown-menu

Here's my take on the subject: image image image

Let me know if this ok and I can submit it.

rgilsimoes avatar Feb 25 '24 20:02 rgilsimoes

@rgilsimoes are you still up for submitting a PR? If your changes keep the current unfocused styles and only move the outline slightly, that seems great to me!

delucis avatar May 20 '24 20:05 delucis

@rgilsimoes are you still up for submitting a PR? If your changes keep the current unfocused styles and only move the outline slightly, that seems great to me!

Will do, got it stashed!

rgilsimoes avatar May 21 '24 20:05 rgilsimoes