docs icon indicating copy to clipboard operation
docs copied to clipboard

Update markdown-content.mdx DE

Open flnzba opened this issue 1 year ago • 6 comments

added frontmatter.title

Description (required)

added frontmatter to post.title because could not recognize title from post without mentioning frontmatter

    {posts.map(post =>
  • {post.**frontmatter**.title}
  • )}

DE

Related issues & labels (optional)

  • Closes #
  • Suggested label:

YES

flnzba avatar Oct 23 '24 14:10 flnzba

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
Latest commit 44e5e57fdcb48445932130b78f456b51624a10f1
Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/672234a06fcc5e000856c948
Deploy Preview https://deploy-preview-9778--astro-docs-2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 23 '24 14:10 netlify[bot]

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes. If they spot any broken links you will see some error messages on this PR. Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes. We try to be responsive, but don’t worry if this takes a few days.

astrobot-houston avatar Oct 23 '24 14:10 astrobot-houston

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

[!NOTE]
The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

Locale File Note
de basics/layouts.mdx Localization changed, will be marked as complete.
de guides/markdown-content.mdx Localization removed, will be marked as missing. 🔄️
de guides/migrate-to-astro.mdx Localization changed, will be marked as complete.
de guides/troubleshooting.mdx Localization changed, will be marked as complete.
de guides/upgrade-to/v3.mdx Localization changed, will be marked as complete.
de reference/api-reference.mdx Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

astrobot-houston avatar Oct 23 '24 15:10 astrobot-houston

Thanks @flnzba, this page's translation is considerably outdated right now, so there's a lot that needs to be updated. We use Lunaria to track the status of each file using Git, so if we merge this PR, normally it would mark as if everything is updated, which is not the case.

Would you like to help us by updating the entire page? Here are all the updates missing that need to be reflected in the translation: https://github.com/withastro/docs/commits/main/src/content/docs/en/guides/markdown-content.mdx?since=2023-08-31T14:47:15.000Z

yanthomasdev avatar Oct 23 '24 16:10 yanthomasdev

Hi @yanthomasdev thank you for the information. I would be interested to contribute something useful to astro. Do I understand correctly: All the changes from all the commits regarding the page markdown-content.mdx

(https://github.com/withastro/docs/commits/main/src/content/docs/en/guides/markdown-content.mdx?since=2023-08-31T14:47:15.000Z)

need to be put into one PR manually so all the changes can be merged?

(In other words the individual commits can not be merged because of Lunaria?)

Kind Regards

flnzba avatar Oct 23 '24 21:10 flnzba

We can merge the individual commits using i18nIgnore in the PR's title, if you just want to get this small change merged we can do that! It's just a preference for us to have the entire page updated instead of only a small part of it. Things tend to get a bit tricky maintenance-wise to review different parts of the same page on different PRs.

yanthomasdev avatar Oct 23 '24 22:10 yanthomasdev

To get all open commits into one PR manually, it would take me a few hours. At the moment I don't have the time to do that. My recommendation would be to check all commits briefly and merge them if no bigger changes are made in the commits (most of them are changing one or two lines). Then check the whole page and make new changes in a bigger commit/PR if necessary... (Just my opinion...)

Maybe Github Workspace Copilot can do this?

flnzba avatar Oct 24 '24 19:10 flnzba

Hi @flnzba ! As Yan mentioned, this page is very out of date, and in fact we were about to remove it entirely as part of our quality checking for outdated content. It is important that translated pages don't lag too far behind the original English content or we risk people relying on incorrect information.

In this case, I think the correct thing to do is go ahead and delete this page entirely from the German translation files. We were going to do that anyway, and so this is actually helpful to us! We can do that in this PR of yours, and then I will close the other PR that updates this same file.

Thank you for helping us with this, and if at some point you would like to contribute to the German translations, you are very welcome! For now, there is too much work to update this single page unless someone is willing to tackle it entirely. And this will be a helpful improvement so people aren't given wrong information.

@sarah11918 Hi Sarah, thank you for your reply!

I will keep my eyes open for meaningful changes I can make to/for Astro and Astro docs.

Kind Regards Florian

flnzba avatar Oct 30 '24 14:10 flnzba