docs icon indicating copy to clipboard operation
docs copied to clipboard

Integration page asides

Open delucis opened this issue 2 years ago • 5 comments

Here’s something that I didn’t get to while working on #954 that would be cool to add to the integration READMEs workflow.

The READMEs currently use a mix of styles for tips and warnings using blockquotes as is common on GitHub. I would like to see these standardised to GitHub’s new syntax for notes and warnings:

> **Note**
> This is a note

> **Warning**
> This is a warning

Note This is a note

Warning This is a warning

THEN I would like to add a remark plugin to our processing pipeline here:

https://github.com/withastro/docs/blob/2c93d8ff0615ac11a6ddcc0b009636c166530fe0/scripts/generate-integration-pages.ts#L73-L77

That finds that syntax and converts it to:

:::note
This is a note
:::

:::caution
This is a warning
:::

delucis avatar Jul 11 '22 19:07 delucis

@delucis If we plan to move much content OUT of the READMEs and into Docs itself, then what's the priority on this, do you feel?

sarah11918 avatar Sep 07 '22 15:09 sarah11918

Depends if we're still using asides in the shorter READMEs or not. I think someone mentioned some things staying README-focused (like Tailwind & Partytown) but if those are the only ones that's one warning instance I can spot currently.

Not high priority I'd say.

delucis avatar Sep 07 '22 22:09 delucis

And, if we NO LONGER IMPORT the content from the READMEs (still an "if" at this point), but instead just link to them in Docs... then we just standardize those README.md files with GitHub aside notation as necessary (whatever remains) but wouldn't need a plugin for docs?

sarah11918 avatar Sep 08 '22 13:09 sarah11918

Was there any consensus on this issue? Standardizing would be quick PR to do :)

Lofty-Brambles avatar Oct 01 '22 19:10 Lofty-Brambles

As it stands currently, we would still need a custom remark plugin that maps GitHub's syntax to our custom aside syntax. Would love a PR for that if you think it's straightforward!

delucis avatar Oct 01 '22 19:10 delucis