docs icon indicating copy to clipboard operation
docs copied to clipboard

Shorter Relative Path

Open fprotazio opened this issue 1 year ago • 4 comments

Description (required)

The relative path const allPosts = await Astro.glob('./posts/*.md'); works as well as const myPosts = await Astro.glob('../pages/posts/*.md');, which is the original. The latter unnecessarily returns to the pages folder.

Related issues & labels (optional)

  • Suggested label: code snippet update, good first issue, help leave feedback.

felipeaprotazio

fprotazio avatar May 06 '24 19:05 fprotazio

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs 🛑 Canceled (Inspect) Jun 14, 2024 7:13pm

vercel[bot] avatar May 06 '24 19:05 vercel[bot]

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes. If they spot any broken links you will see some error messages on this PR. Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes. We try to be responsive, but don’t worry if this takes a few days.

astrobot-houston avatar May 06 '24 19:05 astrobot-houston

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en tutorial/5-astro-api/1.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

astrobot-houston avatar May 06 '24 19:05 astrobot-houston

Hi @felipeaprotazio , thank you for submitting this fix! Yes, you're right, we can make the path shorter here.

In fact, I reviewed everywhere to make sure that if we change this line, we change it in every place, and there is one more place it needs updating: line 51.

Would you please make the change there too, and then I think we have every occurance!

sarah11918 avatar May 21 '24 14:05 sarah11918

Hi @felipeaprotazio , thank you for submitting this fix! Yes, you're right, we can make the path shorter here.

In fact, I reviewed everywhere to make sure that if we change this line, we change it in every place, and there is one more place it needs updating: line 51.

Would you please make the change there too, and then I think we have every occurance!

So sorry for this very, very late reply. I was on a very long vacation and I am just catching up now. I noticed you updated the line 51, too. I appreciate the consistency-oriented mindset Astro team has.

fprotazio avatar Jul 23 '24 18:07 fprotazio