compiler icon indicating copy to clipboard operation
compiler copied to clipboard

🐛 BUG: Compiler error links invalid due to issue forms

Open boehs opened this issue 4 years ago • 5 comments

What version of astro are you using?

0.22.1

What package manager are you using?

pnpm

What operating system are you using?

linux

Describe the Bug

Compiler bugs instruct users to open an issue, but the prefill does not work because of issue forms. Also, they remove flexibility when opening an issue, such as below where a MRE is not needed

Link to Minimal Reproducible Example

n/a

boehs avatar Jan 08 '22 00:01 boehs

What is the suggestion here?

matthewp avatar Jan 08 '22 13:01 matthewp

What is the suggestion here?

  1. Update compiler errors to just spit out what to put into an issue instead of a link to open a new one Or
  2. Remove https://github.com/withastro/astro/blob/main/.github/ISSUE_TEMPLATE/---01-bug-report.yml and replace it with something like https://github.com/boehs/boehs/blob/master/.github/ISSUE_TEMPLATE/what.md, I expect this will allow the prefill to work, and it will give users more flexibility (such as removing the MRE section or adding new sections)
  3. Worst case: remove blank_issues_enabled: false from config.yml

boehs avatar Jan 08 '22 17:01 boehs

Also see: https://github.com/withastro/astro/blob/76195ba40401dc797a9b67cf4a81136849cca2ea/packages/astro/src/vite-plugin-astro/index.ts#L120

boehs avatar Jan 08 '22 17:01 boehs

@boehs, would you be available to put these suggested fixes in a PR?

jonathantneal avatar Jan 21 '22 23:01 jonathantneal

@boehs, would you be available to put these suggested fixes in a PR?

Yeah I'd be down to investigate shortly!

boehs avatar Jan 22 '22 13:01 boehs